refactor(rest/rcp/controllers): Extracted a class from the repeated code within the RPC controllers #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epeated code within the RPC controllers (FunctionController and ProcedureController). Merged FunctionService and ProcedureService into RpcService.
|
Just a note: We had previously used template method pattern to promote reusability. However, we later refactored it to a simpler structure with interfaces and implementations, prioritising readability over reusability. |
|
I understand! Thank's for explaining why it is the way it currently is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common functionality of FunctionController and ProcedureController has been placed into a parent class, RpcApi. Merged FunctionService and ProcedureService into RpcService.
The goal of this is simply to reduce repeated code. If it is planned in the future for the FunctionController to have different functionality from the ProcedureController, feel free to reject this PR.