#215 - refactored bulk create controller

9tigerio · Jan 31, 2024 · 24c06e5 · 24c06e5
1 parent f0fc377
commit 24c06e5
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 11 deletions.
diff --git a/src/main/java/com/homihq/db2rest/rest/create/BulkCreateApi.java b/src/main/java/com/homihq/db2rest/rest/create/BulkCreateApi.java
@@ -0,0 +1,18 @@
+package com.homihq.db2rest.rest.create;
+
+import com.homihq.db2rest.rest.create.dto.CreateBulkResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import org.springframework.http.HttpStatus;
+import org.springframework.web.bind.annotation.*;
+
+public interface BulkCreateApi {
+    @ResponseStatus(HttpStatus.CREATED)
+    @PostMapping(value = "/{tableName}/bulk",
+            consumes = {"application/json", "text/csv"}
+    )
+    CreateBulkResponse save(@PathVariable String tableName,
+                            @RequestHeader(name = "Content-Profile", required = false) String schemaName,
+                            @RequestParam(name = "tsid", required = false) String tsid,
+                            @RequestParam(name = "tsidType", required = false, defaultValue = "number") String tsidType,
+                            HttpServletRequest request) throws Exception;
+}
diff --git a/src/main/java/com/homihq/db2rest/rest/create/BulkCreateController.java b/src/main/java/com/homihq/db2rest/rest/create/BulkCreateController.java
@@ -6,7 +6,6 @@
 import jakarta.servlet.http.HttpServletRequest;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
-import org.springframework.http.HttpStatus;
 import org.springframework.web.bind.annotation.*;
 
 import java.util.List;
@@ -15,21 +14,18 @@
 @RestController
 @Slf4j
 @RequiredArgsConstructor
-public class BulkCreateController {
+public class BulkCreateController implements BulkCreateApi {
 
     private final CreateService createService;
 
     private final List<DataProcessor> dataProcessors;
 
-    @ResponseStatus(HttpStatus.CREATED)
-    @PostMapping (value= "/{tableName}/bulk",
-            consumes = {"application/json", "text/csv"}
-    )
-    public CreateBulkResponse save(@PathVariable String tableName,
-                            @RequestHeader(name = "Content-Profile" , required = false) String schemaName,
-                                          @RequestParam(name = "tsid", required = false) String tsid,
-                                          @RequestParam(name = "tsidType", required = false, defaultValue = "number") String tsidType,
-                            HttpServletRequest request) throws Exception{
+    @Override
+    public CreateBulkResponse save(String tableName,
+                                   String schemaName,
+                                   String tsid,
+                                   String tsidType,
+                                   HttpServletRequest request) throws Exception{
 
         DataProcessor dataProcessor = dataProcessors.stream()
                 .filter(d -> d.handle(request.getContentType()))