Files hadn't been saved for last commit

3dmol · Aug 31, 2024 · 4164b52 · 4164b52
1 parent cc817a8
commit 4164b52
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/src/Label.ts b/src/Label.ts
@@ -123,11 +123,13 @@ export class Label {
     return this.stylespec;
   }
 
-  hide() {
+  /** Hide this label. */
+  public hide() {
     this.sprite.visible = false;
   }
 
-  show() {
+  /** Show a hidden label. */
+  public show() {
 
     this.sprite.visible = true;
   }

diff --git a/src/WebGL/SpritePlugin.ts b/src/WebGL/SpritePlugin.ts
@@ -207,10 +207,12 @@ export class SpritePlugin {
     let sprites: unknown[] = [];
     scene?.__webglSprites?.forEach((sprite) => {
       //depthTest is false for inFront labels
-      if (inFront && sprite.material.depthTest == false) {
-        sprites.push(sprite);
-      } else if (!inFront && sprite.material.depthTest) {
-        sprites.push(sprite);
+      if (!sprite.hidden) {
+        if (inFront && sprite.material.depthTest == false) {
+          sprites.push(sprite);
+        } else if (!inFront && sprite.material.depthTest) {
+          sprites.push(sprite);
+        }
       }
     });
 
@@ -340,10 +342,10 @@ export class SpritePlugin {
             uniforms.screenPosition,
             (sprite.position.x * this.renderer.devicePixelRatio -
               halfViewportWidth) /
-              halfViewportWidth,
+            halfViewportWidth,
             (halfViewportHeight -
               sprite.position.y * this.renderer.devicePixelRatio) /
-              halfViewportHeight,
+            halfViewportHeight,
             Math.max(0, Math.min(1, sprite.position.z))
           );
         } else {

diff --git a/src/WebGL/objects/Sprite.ts b/src/WebGL/objects/Sprite.ts
@@ -9,7 +9,6 @@ export class Sprite extends Object3D {
   _modelViewMatrix: any;
   z?: number;
   material?: Material;
-  hidden = false;
 
   constructor(material = new SpriteMaterial() as Material) {
     super();