Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosened the dependency version of Click #243

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

oharsta
Copy link

@oharsta oharsta commented Jan 13, 2022

Pinning the version of Click makes it impossible to upgrade to other often used dependencies like Celery.

Pinning the version of Click makes it impossible to upgrade other
often used dependencies like Celery.
@ottonomy ottonomy self-requested a review January 24, 2022 20:10
Copy link
Collaborator

@ottonomy ottonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good PR. We could stand to loosen several other requirements as well, but this is a fine start, and it unblocks @oharsta's work once merged and a new release tagged.

@cawrosendo
Copy link

it would be great if pytz requirement is also loosened since celery 5.2 depends on pytz >= 2021.3 and openbadges only uses pytz.utc which hasn't changed

@fransward
Copy link

We would like to see this approved PR merged. Anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants