Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Feature/use new snapshots #339

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Feature/use new snapshots #339

merged 8 commits into from
Jul 7, 2023

Conversation

darylldoyle
Copy link
Collaborator

Description of the Change

This PR updates the local docker system to utilise the new Snapshots WP-CLI command rather than the prior docker-based WP Snapshots system.

This has the following benefits:

  • Removes the need for a dedicated snapshots container.
  • Removes the issue with WP Snapshots running on PHP 8+ codebases
  • Makes Snapshots more extensible

Closes #332 #316 #305

How to test the Change

  • Clone the repo and checkout this branch.
  • Open the directory in a terminal
  • Build the codebase
    • nvm use
    • npm run build
  • Create a new environment and do the following within it
    • Ensure the new WP-CLI command is working
      • npm run 10updocker wp snapshots search <something>
    • Ensure the old command is proxying to the new WP-CLI command
      • npm run 10updocker wpsnapshots search <something>
      • npm run 10updocker snapshots search <something>
  • Update an existing environment to ensure the phpfpm container can access the required directories (see below)
    • Ensure the new WP-CLI command is working
      • npm run 10updocker wp snapshots search <something>
    • Ensure the old command is proxying to the new WP-CLI command
      • npm run 10updocker wpsnapshots search <something>
      • npm run 10updocker snapshots search <something>
  phpfpm:
      image: '10up/wp-php-fpm-dev:7.4-ubuntu'
      # ...
      volumes:
         # ...
          - '~/.wpsnapshots:/home/www-data/.wpsnapshots:cached'
          - '~/.aws:/home/www-data/.aws:cached'

Changelog Entry

Changed - Snapshots are now using the Snapshots WP-CLI command

Credits

Props @tlovett1, @darylldoyle

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@darylldoyle darylldoyle added the enhancement New feature or request label Jun 30, 2023
@darylldoyle darylldoyle requested a review from tlovett1 June 30, 2023 23:26
@darylldoyle darylldoyle self-assigned this Jun 30, 2023
@darylldoyle darylldoyle added this to the 4.0.0 milestone Jul 6, 2023
README.md Outdated Show resolved Hide resolved
@darylldoyle darylldoyle merged commit d13d21a into develop Jul 7, 2023
@darylldoyle darylldoyle deleted the feature/use-new-snapshots branch July 7, 2023 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.2 support
2 participants