Merge pull request #173 from jjikky/refactor/objet-create-update

오브제 수정 삭제 sharers 데이터 타입 변경
100-hours-a-week · Sep 2, 2024 · 807489a · 807489a
2 parents 6a234b7 + c45170c
commit 807489a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 17 deletions.
diff --git a/src/main/java/com/example/daobe/objet/application/ObjetService.java b/src/main/java/com/example/daobe/objet/application/ObjetService.java
@@ -29,9 +29,6 @@
 import com.example.daobe.user.domain.User;
 import com.example.daobe.user.domain.repository.UserRepository;
 import com.example.daobe.user.exception.UserException;
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.core.type.TypeReference;
-import com.fasterxml.jackson.databind.ObjectMapper;
 import java.util.Comparator;
 import java.util.List;
 import java.util.Set;
@@ -55,7 +52,6 @@ public class ObjetService {
     private final ChatService chatRoomService;
     private final ObjetCallRepository objetCallRepository;
     private final ApplicationEventPublisher eventPublisher;
-    private final ObjectMapper objectMapper = new ObjectMapper();
 
     @Transactional
     public ObjetCreateResponseDto create(Long userId, ObjetCreateRequestDto request) {
@@ -75,7 +71,7 @@ public ObjetCreateResponseDto create(Long userId, ObjetCreateRequestDto request)
                 .build();
         objetRepository.save(objet);
 
-        List<Long> sharerIds = parseSharerData(request.sharers());
+        List<Long> sharerIds = request.sharers();
         sharerIds.add(userId);
 
         List<ObjetSharer> objetSharers = manageSharers(objet, sharerIds, userId);
@@ -97,7 +93,7 @@ public ObjetCreateResponseDto update(Long userId, Long objetId, ObjetUpdateReque
         }
 
         Set<Long> currentSharerIds = getCurrentSharerIds(findObjet);
-        List<Long> newSharerIds = parseSharerData(request.sharers());
+        List<Long> newSharerIds = request.sharers();
         manageAndSyncSharers(findObjet, currentSharerIds, newSharerIds, userId);
 
         objetRepository.save(findObjet);
@@ -199,15 +195,6 @@ private Set<Long> getCurrentSharerIds(Objet findObjet) {
                 .collect(Collectors.toSet());
     }
 
-    private List<Long> parseSharerData(String sharers) {
-        try {
-            return objectMapper.readValue(sharers, new TypeReference<>() {
-            });
-        } catch (JsonProcessingException e) {
-            throw new RuntimeException(e);
-        }
-    }
-
     private List<ObjetSharer> manageSharers(Objet objet, List<Long> sharerIds, Long userId) {
         return sharerIds.stream()
                 .map(sharerId -> {

diff --git a/src/main/java/com/example/daobe/objet/application/dto/ObjetCreateRequestDto.java b/src/main/java/com/example/daobe/objet/application/dto/ObjetCreateRequestDto.java
@@ -1,7 +1,9 @@
 package com.example.daobe.objet.application.dto;
 
+import java.util.List;
+
 public record ObjetCreateRequestDto(
-        String sharers,
+        List<Long> sharers,
         String name,
         String description,
         String type,

diff --git a/src/main/java/com/example/daobe/objet/application/dto/ObjetUpdateRequestDto.java b/src/main/java/com/example/daobe/objet/application/dto/ObjetUpdateRequestDto.java
@@ -1,11 +1,12 @@
 package com.example.daobe.objet.application.dto;
 
+import java.util.List;
 import lombok.Builder;
 
 @Builder
 public record ObjetUpdateRequestDto(
         Long objetId,
-        String sharers,
+        List<Long> sharers,
         String name,
         String description,
         String objetImage