waas: sign message change (#20)

* waas: sign message change * waas: sign message change
0xsequence · Feb 16, 2024 · 80f65eb · 80f65eb
1 parent a7b4afb
commit 80f65eb
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 6 deletions.
diff --git a/go.mod b/go.mod
@@ -4,7 +4,7 @@ go 1.21.5
 
 require (
 	github.com/0xsequence/ethkit v1.22.4
-	github.com/0xsequence/go-sequence v0.25.1-0.20240215085151-03a5ef4a2143
+	github.com/0xsequence/go-sequence v0.25.1-0.20240216130731-cc4e560c3e52
 	github.com/0xsequence/nitrocontrol v0.3.0
 	github.com/BurntSushi/toml v1.3.2
 	github.com/aws/aws-sdk-go-v2 v1.24.1

diff --git a/go.sum b/go.sum
@@ -3,8 +3,8 @@ github.com/0xsequence/ethkit v1.22.4 h1:hd6DYnQ/8l1mC7ZcUOyYlD3pgCfKKAClkrtpU2hO
 github.com/0xsequence/ethkit v1.22.4/go.mod h1:wBcLTM7WpGCJnQyYUvUIRLbjurDrkSMHCKuOu/rylro=
 github.com/0xsequence/go-ethauth v0.13.0 h1:ZaqFEEqy574A2b1P7vjpcy5tb4W/izn+A3swwOYi9wA=
 github.com/0xsequence/go-ethauth v0.13.0/go.mod h1:f3kx39S9F+W+qvZEB6bkKKbpUstmyB7goUntO3wvlhg=
-github.com/0xsequence/go-sequence v0.25.1-0.20240215085151-03a5ef4a2143 h1:gobYr+Ss6WrQkBD/8dg3Cp7OBpj6lhDVIFM/MEw8ybo=
-github.com/0xsequence/go-sequence v0.25.1-0.20240215085151-03a5ef4a2143/go.mod h1:De76GvRmR+zFnbpe8c5l9iTe9Hgs1Bc7WIZem4XdEq8=
+github.com/0xsequence/go-sequence v0.25.1-0.20240216130731-cc4e560c3e52 h1:KOMKfE2Bly4mMW8ddTSoBCe2Jkz7pf7T5oUpvsDdMjo=
+github.com/0xsequence/go-sequence v0.25.1-0.20240216130731-cc4e560c3e52/go.mod h1:De76GvRmR+zFnbpe8c5l9iTe9Hgs1Bc7WIZem4XdEq8=
 github.com/0xsequence/nitrocontrol v0.3.0 h1:D0/gX576zQhitrJnBfBrOFFufEOzh6f2jO/+2ynwIUA=
 github.com/0xsequence/nitrocontrol v0.3.0/go.mod h1:sTG5akVPzoVr3unv/7h9aZGaT+BVGmvUMOdwXFeIEEA=
 github.com/0xsequence/nsm v0.1.0 h1:gVOViRWPUW/c5VEmGy2gCw1az/nqP3gY7VD9V2+069k=

diff --git a/rpc/sign_message.go b/rpc/sign_message.go
@@ -24,8 +24,11 @@ func (s *RPC) signMessage(
 		return nil, fmt.Errorf("recovering parent wallet: %w", err)
 	}
 
+	// Make sure the message is EIP191 encoded
+	msgBytes := sequence.MessageToEIP191(common.FromHex(intent.Data.Message))
+
 	// Validate that message match intent
-	digest := sequence.MessageDigest(common.FromHex(intent.Data.Message))
+	digest := sequence.MessageDigest(msgBytes)
 
 	chainID, ok := sequence.ParseHexOrDec(intent.Data.Network)
 	if !ok {

diff --git a/vendor/github.com/0xsequence/go-sequence/intents/intent_data_sign_message_ext.go b/vendor/github.com/0xsequence/go-sequence/intents/intent_data_sign_message_ext.go
diff --git a/vendor/modules.txt b/vendor/modules.txt
@@ -35,7 +35,7 @@ github.com/0xsequence/ethkit/go-ethereum/rpc
 # github.com/0xsequence/go-ethauth v0.13.0
 ## explicit; go 1.17
 github.com/0xsequence/go-ethauth
-# github.com/0xsequence/go-sequence v0.25.1-0.20240215085151-03a5ef4a2143
+# github.com/0xsequence/go-sequence v0.25.1-0.20240216130731-cc4e560c3e52
 ## explicit; go 1.18
 github.com/0xsequence/go-sequence
 github.com/0xsequence/go-sequence/contracts