-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fetch real data for wallet hardcoded wallet address #39
Merged
pkieltyka
merged 35 commits into
master
from
Feature/fetchRealDataForWallet_hardcodedWalletAddress
Oct 26, 2023
Merged
Feature/fetch real data for wallet hardcoded wallet address #39
pkieltyka
merged 35 commits into
master
from
Feature/fetchRealDataForWallet_hardcodedWalletAddress
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…they don't interfere with the build process
…taForWallet_hardcodedWalletAddress
…entFetcher and TokenContentFetcher, which are essentially wrappers for ContentFetcher
…s sent by Indexer. Fixed error with content fetching by removing an unsupported Chain
…ctions asynchronously
…les case when the indexer is down for a given chain. This logs a warning and points to the indexer status page as a first thing to check
…e async messages to abort silently
…as well) to the lists in parallel
…igure out an ideal starting place for devs to work with
…y to freeze (infinite loop) when clicking on any of the wallet elements and trying to open their info page
…population. Fix memory leaks associated with web requests
… wallet - i.e. those where we couldn't fetch the image
…taForWallet_hardcodedWalletAddress
pkieltyka
deleted the
Feature/fetchRealDataForWallet_hardcodedWalletAddress
branch
October 26, 2023 17:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisite PR: #37
Implemented a ContentFetcher - an integration with the Indexer that fetches tokens and NFTs from every supported chain
Real implementations for INftContentFetcher and ITokenContentFetcher interfaces
Added a basic end to end test for the content fetchers loading info into the WalletPage
Integration tested on:
-MacOS
-Android
-iOS
-WebGL
All issues found have been resolved
RealData.mov