Feature/waas integration #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eir own files. Expanded ISignature to contain additional methods that were added recently
…ng and an Address can be implicitly converted between one and another. This means that an instance of the Address class is not necessarily a valid Ethereum address.
… the constructor. This allows us to guarantee that an Address is a valid Ethereum address
…tories, and namespaces as appropriate.
…espace - opting for Sequence.Core instead.
…ds for bool, UInt16, and UInt32 - added unit tests for these extensions.
…the IWallet defined in SequenceWaaS. The adapter implements SequenceEthereum-IWallet using SequenceWaaS-IWallet as a dependency. Implemented the GetAddress adapter - note that since SequenceWaaS and SequenceEthereum have a different concept of what a wallet is, some of SequenceEthereum-IWallet may need to be modified slightly. For example: when implementing GetAddress, I've added an optional parameter to the method to specify the accountIndex as SequenceWaaS wallets can have multiple accounts/addresses while SequenceEthereum wallets have only one.
…tract transaction
…nd ripped System.Linq out of another class.
…r getting wallet addressfrom jwt and fixed implementation
…reate this as it doesn't need any parameters
…w transactions is replaced with send EthTransaction
…Fixed implementation so that the test passes
…send basic transfers
…aitForReceipts. Added respective tests
…r WaaS as it errors on 0x0 (which is usually expected). Pre-calculate contract deployment address - WaaS transaction receipts don't expose this.
taylanpince
requested changes
Dec 18, 2023
taylanpince
requested changes
Dec 18, 2023
taylanpince
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
Since this PR is rather large, I'd recommend starting the review with:
Pre-requisite: #19 #27