3627 remove isdev from exposed interface #193
Conversation
andrewlee348
requested review from
corbanbrook,
tolgahan-arikan,
attente and
SamueleA
There was a problem hiding this comment.
There are two improvement that I think would be necessary for this:
-
Can we use have the DEVMODE variable be read from an environment variable?
-
Can we remove the
isDevparameter from the kitConfig and then replace instances in which isDev would normally be used with that DEVMODE variable?
https://github.com/0xsequence/kit/blob/master/packages/kit/src/types.ts#L78
|
@SamueleA I must've forgotten to push my latest changes. I've removed all isDev from config and kit packages and added a workaround for env variables since the packages aren't able to read env variables from outside the packages folder. |
andrewlee348
force-pushed
the
3627-remove-isdev-from-exposed-interface
branch
2 times, most recently
from
5dec4a3 to
57e0b91
Compare
andrewlee348
force-pushed
the
3627-remove-isdev-from-exposed-interface
branch
2 times, most recently
from
dd2b5c5 to
9f6016b
Compare
andrewlee348
force-pushed
the
3627-remove-isdev-from-exposed-interface
branch
7 times, most recently
from
2817ec6 to
cdcae2b
Compare
andrewlee348
force-pushed
the
3627-remove-isdev-from-exposed-interface
branch
from
cdcae2b to
8e513a5
Compare
| @@ -0,0 +1,12 @@ | |||
| const fs = require('fs') | |||
There was a problem hiding this comment.
Should not generate an env file that overrides env.ts
There was a problem hiding this comment.
This would potentially get committed into the code base.
| @@ -0,0 +1 @@ | |||
| export const DEVMODE = false | |||
There was a problem hiding this comment.
This file should simply reexport the process.env.DEVMODE
There was a problem hiding this comment.
or process.env.DEVMODE should just be used directly instead
No description provided.