experimental google auth redirect #146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkieltyka
reviewed
Sep 25, 2024
| @@ -31,6 +31,7 @@ import { ExtendedWalletList } from './ExtendedWalletList' | |||
| interface ConnectWalletContentProps extends KitConnectProviderProps { | |||
| emailConflictInfo?: FormattedEmailConflictInfo | null | |||
| onClose: () => void | |||
| googleUxMode?: 'popup' | 'redirect' | |||
There was a problem hiding this comment.
can we rename to "redirectMode" and make it a boolean, default is false, therefore popup..? this way, we can leverage this for any other related auth provider too..?
lmk if you think otherwise too..?
bunnybones1
force-pushed
the
google-ux-mode-redirect
branch
4 times, most recently
from
878e07d to
ccdc291
Compare
bunnybones1
force-pushed
the
google-ux-mode-redirect
branch
from
ccdc291 to
255ad38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.