-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for events: RollbackBatches and UpdateL1InfoTreeV2 #101
Merged
joanestebanr
merged 20 commits into
develop
from
feature/100-RollbackBatches_UpdateL1InfoTreeV2
Aug 28, 2024
Merged
Add support for events: RollbackBatches and UpdateL1InfoTreeV2 #101
joanestebanr
merged 20 commits into
develop
from
feature/100-RollbackBatches_UpdateL1InfoTreeV2
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due import cycles
… due import cycles
joanestebanr
requested review from
ARR552,
agnusmor and
ToniRamirezM
as code owners
August 28, 2024 12:34
ToniRamirezM
approved these changes
Aug 28, 2024
joanestebanr
deleted the
feature/100-RollbackBatches_UpdateL1InfoTreeV2
branch
August 28, 2024 14:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100
What does this PR do?
UpdateL1InfoTreeV2
: basically is a sanity check for L1InfoTreeRollbackBatches
:etherman
: move types to another folder to be able to do mock and prevent import cycle error (most of the files changes are for that reason!)debug
Reviewers
Main reviewers:
@ToniRamirezM