Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming, improving logs, cleaning #132

Open
wants to merge 67 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
bdcaf39
new values! macro + tests
sam0x17 Dec 2, 2024
4a3623c
upgrade parsing
sam0x17 Dec 3, 2024
db76716
WIP
sam0x17 Dec 3, 2024
c909bac
also parse fields
sam0x17 Dec 4, 2024
1dfbf6a
fix parsing
sam0x17 Dec 4, 2024
d8773b7
add more tests
sam0x17 Dec 4, 2024
041c7ab
num_rows
sam0x17 Dec 4, 2024
ea9c695
commit_id
sam0x17 Dec 4, 2024
e704e3e
working.....?
sam0x17 Dec 4, 2024
806cae4
Simplifying macro and commenting commit_id
RogerTaule Dec 5, 2024
aabbb66
Renaming, improving logs, cleaning
RogerTaule Dec 4, 2024
2a7073d
Removing map_buffer from tests
RogerTaule Dec 4, 2024
7f04e6d
Working on AirInstance improvements
RogerTaule Dec 5, 2024
abaf007
Work in progress
RogerTaule Dec 5, 2024
88dbc73
Keep working on cleaning
RogerTaule Dec 5, 2024
2d42516
Cleaning completed
RogerTaule Dec 9, 2024
5c46416
Minor fix
RogerTaule Dec 9, 2024
ce82455
fixing ci
RogerTaule Dec 9, 2024
9c942c5
Minor changes and starting cleaning unsafes from ffi
RogerTaule Dec 9, 2024
f27bf26
Cargo fmt
RogerTaule Dec 9, 2024
8f8ab9e
Cargo clippy
RogerTaule Dec 9, 2024
91d992a
Keep cleaning c_void
RogerTaule Dec 9, 2024
accbe0e
Removing slice_trace
RogerTaule Dec 9, 2024
d6f19fa
Updating macro with optional custom commit
RogerTaule Dec 9, 2024
7e2b39b
Fix
RogerTaule Dec 9, 2024
5c20eb9
Improving AirInstance calls
RogerTaule Dec 10, 2024
1a7578c
Clippy fix
RogerTaule Dec 10, 2024
2cc1a1c
All tests pasing
RogerTaule Dec 10, 2024
c0625c6
Improving pil-helpers airvalues
RogerTaule Dec 10, 2024
dd6e4c5
Fixing airgroupvalues to be compatible with new airvalues handling
RogerTaule Dec 10, 2024
cb1006f
Fixing cargo fmt
RogerTaule Dec 10, 2024
b997644
add dctx function
xavi-pinsach Dec 11, 2024
9795265
Removing setup ctx from air_instance
RogerTaule Dec 11, 2024
ca7f807
Merge branch 'develop' into feature/minor_clean
RogerTaule Dec 12, 2024
7e6b205
Pointing to 0.0.17 pil2-proofman-js
RogerTaule Dec 12, 2024
5ed06d3
Fix C++ compilation
RogerTaule Dec 12, 2024
a6ecfd6
Fix ffi when no_lib_link
RogerTaule Dec 12, 2024
8e10ab8
Compilation fibonacci error
RogerTaule Dec 12, 2024
8a8a5fd
Removing execution ctx
RogerTaule Dec 13, 2024
8480f61
More cleaning
RogerTaule Dec 13, 2024
b4f007a
Still more cleaning
RogerTaule Dec 13, 2024
2b18050
Merge branch 'develop' into feature/minor_clean
RogerTaule Dec 13, 2024
7d1bd95
Keep cleaning
RogerTaule Dec 13, 2024
d02c372
Simplifying all witness logic
RogerTaule Dec 16, 2024
c21166b
Adding custom-commits common
RogerTaule Dec 16, 2024
96d872b
Minor changes
RogerTaule Dec 16, 2024
2c86d0a
Adding proof values to transcript
RogerTaule Dec 18, 2024
b63bd31
Fixing global info json
RogerTaule Dec 18, 2024
0321ecb
Fix pctx
RogerTaule Dec 18, 2024
60b1ca4
Adding some information to print_summary
RogerTaule Dec 19, 2024
a2773ea
Fix
RogerTaule Dec 19, 2024
25422c3
Typo
RogerTaule Dec 19, 2024
4b7a506
Typo
RogerTaule Dec 19, 2024
49d58ee
cleaning Cargo.toml(s)
xavi-pinsach Dec 20, 2024
100b2f0
add log create to starks-lib-c
xavi-pinsach Dec 20, 2024
95eb57f
Removing all unsafes from hints
RogerTaule Dec 20, 2024
b90c886
add with_capacity function to Trace macro
xavi-pinsach Dec 23, 2024
d94c07f
Removing unsafes from verify constraints
RogerTaule Dec 23, 2024
b41483e
Activating back distributed mode and adding test to CI
RogerTaule Dec 23, 2024
5c667b4
Fixing test
RogerTaule Dec 23, 2024
d875801
Merge branch 'develop' into feature/minor_clean
RogerTaule Dec 23, 2024
d97ed12
Adding get constraints method and fix ci
RogerTaule Dec 23, 2024
f214257
Minor changes
RogerTaule Dec 23, 2024
5e6d671
Minor improvements, prepare for debugging mode
RogerTaule Dec 23, 2024
0c35e2a
Cargo fmt
RogerTaule Dec 23, 2024
6e96402
Distributed working, missing verify constraints and recursion
RogerTaule Dec 24, 2024
fa968a2
Improving debugging
RogerTaule Dec 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ jobs:
repository: iden3/circom
path: circom-repo


- name: Build and install Circom
working-directory: circom-repo
run: |
Expand All @@ -158,7 +159,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: 0xPolygonHermez/pil2-proofman-js
ref: feature/setup
ref: feature/minor_clean
path: pil2-proofman-js

- name: Install pil2-proofman-js dependencies
Expand All @@ -169,7 +170,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: 0xPolygonHermez/pil2-compiler
ref: feature/on-final-priority
ref: feature/proofval-stage
path: pil2-compiler

- name: Install pil2-compiler dependencies
Expand All @@ -181,6 +182,7 @@ jobs:
sudo apt-get update
sudo apt-get install -y protobuf-compiler
sudo apt install -y build-essential libbenchmark-dev libomp-dev libgmp-dev nlohmann-json3-dev nasm libsodium-dev cmake
sudo apt-get install -y openmpi-bin libopenmpi-dev

- name: Install pil2-stark
working-directory: pil2-stark
Expand Down Expand Up @@ -224,6 +226,21 @@ jobs:
- name: Verify proof Fibonacci Square
run: |
node pil2-proofman-js/src/main_verify -k examples/fibonacci-square/build/provingKey -p examples/fibonacci-square/build/proofs -t vadcop_final

- name: Clean proof dir
run: |
rm -rf examples/fibonacci-square/build/proofs

- name: Cargo build distributed
run: RUST_BACKTRACE=1 cargo build --features distributed -v

- name: Generate proof Fibonacci Square distributed
run: |
mpirun --bind-to none -np 3 -x OMP_NUM_THREADS=32 target/debug/proofman-cli prove --witness-lib ./target/debug/libfibonacci_square.so --public-inputs examples/fibonacci-square/src/inputs.json --proving-key examples/fibonacci-square/build/provingKey/ --output-dir examples/fibonacci-square/build/proofs -a

- name: Verify proof Fibonacci Square distributed
run: |
node pil2-proofman-js/src/main_verify -k examples/fibonacci-square/build/provingKey -p examples/fibonacci-square/build/proofs -t vadcop_final
test-std:
name: Test STD
runs-on: ubuntu-latest
Expand Down Expand Up @@ -260,7 +277,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: 0xPolygonHermez/pil2-proofman-js
ref: feature/setup
ref: feature/minor_clean
path: pil2-proofman-js

- name: Install pil2-proofman-js dependencies
Expand All @@ -271,7 +288,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: 0xPolygonHermez/pil2-compiler
ref: feature/on-final-priority
ref: feature/proofval-stage
path: pil2-compiler

- name: Install pil2-compiler dependencies
Expand Down
Loading
Loading