Isolated term into sum #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerTaule
force-pushed
the
feature/isolated-term
branch
from
33f299f to
56cbc49
Compare
hecmas
force-pushed
the
feature/isolated-term
branch
from
59f2c68 to
c21c8d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include the addition of handling for isolated terms in expressions.
Enhancements to expression handling:
pil2-components/lib/std/pil/std_sum.pil: Added handling for isolated terms in expressions to optimize the transformation process. This includes identifying isolated terms, computing their numerators and denominators, and updating the gsum constraint accordingly.Updates to Rust implementation:
pil2-components/lib/std/rs/src/std_sum.rs: Updated theWitnessComponentimplementation to handle isolated terms by adding new hint fields and updating the computation of thegsumvalue.New test file:
pil2-components/test/std/special/table.pil: Added a new test file to verify the functionality of isolated terms handling.