Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using from A import * #4

Open
zxul767 opened this issue Jul 27, 2022 · 0 comments
Open

Stop using from A import * #4

zxul767 opened this issue Jul 27, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@zxul767
Copy link
Owner

zxul767 commented Jul 27, 2022

This is a common practice in fastai notebooks and while it is probably harmless in the context of the course, I think it's a bad practice in general due to the potential for silent shadowing of function and variable names.

We should rewrite the notebooks to use the more commonly used practice of using a very short but common prefix. pandas uses pd, numpy uses np, seaborn uses sns, etc.

@zxul767 zxul767 added the enhancement New feature or request label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant