Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

使用「设备特定选项」导致配置丢失 #7

Open
TCOTC opened this issue Jan 26, 2024 · 5 comments
Open

使用「设备特定选项」导致配置丢失 #7

TCOTC opened this issue Jan 26, 2024 · 5 comments

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Jan 26, 2024

上面的配置一个个选好之后，点击了下图所示的区域，会导致思源界面重载。上面的配置因为没有保存而全部丢失。

image
@zxkmm
Copy link
Owner

zxkmm commented Jan 26, 2024 •
edited
Loading

谢谢反馈，这个按钮目前可能只能写成点击后重载，因为思源官方的设置项没给数值改变后的回调方法，所以没办法实时更新上方那个列表值，我只能写了一个assignValue函数直接操控配置项存储，

siyuan_doctree_compress/src/libs/setting-utils.ts

Line 71 in 95f6043

async assignValue(_key_: string, _value_: any) {

如果点击不重载页面的话，就没法添加内容到列表。
用svelte重写整个设置页面后应该能解决，但是我现在暂时没有精力重写。
我当时为了图方便用了官方的设置项，结果现在连标签都没法实现。

@TCOTC TCOTC mentioned this issue Jan 26, 2024
Merged
@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 26, 2024

感觉目前可能需要一段注释来提示用户不要随便点，就像 #9 这样

zxkmm added a commit that referenced this issue Jan 26, 2024
@TCOTC @zxkmm
使用「设备特定选项」时的警告 (#9)
958ff5e 
* Update en_US.json #7

#7

* Update zh_CN.json #7

#7

---------

Co-authored-by: sommermoregentraum <[email protected]>
@zxkmm
Copy link
Owner

zxkmm commented Jan 26, 2024

感觉目前可能需要一段注释来提示用户不要随便点，就像 #9 这样

感谢！已合并

@TCOTC
Copy link
Contributor Author

TCOTC commented May 4, 2024

这个按钮目前可能只能写成点击后重载

话说不能先保存再重载吗？

@zxkmm
Copy link
Owner

zxkmm commented May 4, 2024 •
edited
Loading

保存的回调在保存按钮的点击事件上，我不想把模版框架改的太多，然后以后模版升级会方便一些

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zxkmm @TCOTC