Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't transmit error instances for protocol 5 #57

Open
jimfulton opened this issue Aug 3, 2016 · 0 comments
Open

Don't transmit error instances for protocol 5 #57

jimfulton opened this issue Aug 3, 2016 · 0 comments

Comments

@jimfulton
Copy link
Member

Error handling is awkward in a number of ways:

  • Detecting errors involves sniffing results in ways that seem like bug magnets.
  • We're required to pickle error objects, with the security issues that entails.
    • We shouldn't need to pickle objects at the protocol level.
    • We might want to use alternate serialization formats that don't support object serialization.

Instead, we'll send dotted error class names and arguments and we'll use the async flag as an error flag in replies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant