Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the find_global/server_find_global shims #241

Open
tseaver opened this issue Jun 17, 2024 · 1 comment
Open

Remove the find_global/server_find_global shims #241

tseaver opened this issue Jun 17, 2024 · 1 comment

Comments

@tseaver
Copy link
Member

tseaver commented Jun 17, 2024

They exist only for Python2 compatibility (and not at the level of pickle opcodes). Nothing in the Python3 stdlib knows about any find_global, which was historically (in Python2) just a way to expose the C-level find_class. Stuffing a new implementation into the module global hasn't had any effect on how cPickle_pickle_33 actually worked since we dropped Python2 support.

$ rgrep find_global /opt/src/Python-3.3.7/ && echo FOUND || echo NOT FOUND
NOT FOUND

See https://github.com/zopefoundation/zodbpickle/pull/74/files

@tseaver
Copy link
Member Author

tseaver commented Jun 17, 2024

See PR #237.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant