Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of probability distribution function #7

Open
zmek opened this issue Jul 15, 2024 · 0 comments
Open

Improve performance of probability distribution function #7

zmek opened this issue Jul 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@zmek
Copy link
Owner

zmek commented Jul 15, 2024

Describe the Bug

predict.emergency_demand.from_individual_probs.get_prob_dist_for_prediction_moment() returns a probability distribution over the number of rows in X_test. When there are many rows in the snapshot, performance is very slow. This is due to the cumulative product expression in build_expression().

To Reproduce

https://github.com/zmek/zbeds/blob/zbeds2-discharge-modelling/models/discharges/notebooks/Python_model_discharges.ipynb

Expected Behaviour

Was as expected but very slow

Actual Behaviour

Consider truncating the distribution based on the number of observed patients?

Version In Use

0

Additional Context

- Python version:
- Operating system:
@zmek zmek added the bug Something isn't working label Jul 15, 2024
@zmek zmek self-assigned this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant