Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification conflict. #28

Open
Khikki opened this issue Jun 4, 2020 · 5 comments
Open

Modification conflict. #28

Khikki opened this issue Jun 4, 2020 · 5 comments

Comments

@Khikki
Copy link

Khikki commented Jun 4, 2020

Hello, as I understand it, several modifications conflict with 'SkinPort', such as 'Twilight Forest', 'Headcrumbs', upd 'Botania'.

Twilight Forest - Giant Miner.
2020-06-04_21 46 50

Headcrumbs - Heads.
2020-06-04_21 48 08

Headcrumbs - Human.
2020-06-04_21 48 25

Botania - Gaia Guardian's and Head.
2020-06-05_03 04 44

I understand that most likely it will have to patch the modifications themselves, do you have any ideas how to fix it?

@H4kt
Copy link

H4kt commented Jun 5, 2020

Having a lot of trouble with it too.

@H4kt
Copy link

H4kt commented Jun 6, 2020

Regarding TwilightForest (and probably Headcrumbs) the issue is being caused by the mods itself
Here is an extract from the render class for Giant

public RenderTFGiant() {
    super(new ModelBiped(), 0.625F);
    this.textureLoc = new ResourceLocation("textures/entity/steve.png");
}

As you see it uses vanilla's model to render which grabs the unsupported texture.
But I actually found out that you can fix it using RenderLivingEvent.Pre
Here is the Gist, not the cleaneast solution and could potentially break some other mods.
https://gist.github.com/H4kt/8cf101aced9fa39b4b332da6e71a1400

But somehow it keeps breaking the rendering of held item
image

@H4kt
Copy link

H4kt commented Jun 6, 2020

The soution for skulls might be very similar to this one

@zlainsama
Copy link
Owner

Sorry, I don't really want to patch this mod for every incompatibilities...
This mod is licensed under MIT, please feel free to fork it, and make your own patches.

@Roadhog360
Copy link

Roadhog360 commented Feb 3, 2021

These comments will be noted for a fix in Et Futurum Requiem's Alex model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants