Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What Slice Definitions Should swift:attribute be Allowed on? #3259

Open
InsertCreativityHere opened this issue Dec 11, 2024 · 0 comments
Open

Comments

@InsertCreativityHere
Copy link
Member

Swift supports a swift:attribute metadata, for adding attributes into the generated code. But, there's a major inconsistency in it.

The code-gen checks for this metadata on struct, but the validation rejects it on structs.
So, if you put swift:attribute on a struct, the validation removes it and warns you, even though the code-gen could of used it.

And the code-gen ignores this metadata on interface, but the validation allows it on interface.
So, if you put swift:attribute on an interface, the validation is happy, but it does absolutely nothing.

The documentation for this metadata says it's only supported on class, exception, and enum?
There is no mention of either struct or interface.


I'm not familiar with Swift, but only allowing it on class, exception, and enum feels like a weird list.
Should this be supported on struct?, on interface?, on anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant