Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify IceGrid instance name computation #3133

Open
externl opened this issue Nov 12, 2024 · 1 comment
Open

Simplify IceGrid instance name computation #3133

externl opened this issue Nov 12, 2024 · 1 comment
Milestone

Comments

@externl
Copy link
Member

externl commented Nov 12, 2024

We currently have a complicated process for determining the IceGrid instance name:

    // The IceGrid instance name. We can't use getIceProperty as we don't want to get any default values.
    string instanceName = properties->getProperty("IceGrid.InstanceName");
    if (instanceName.empty())
    {
        instanceName = properties->getProperty("IceLocatorDiscovery.InstanceName");
    }
    if (instanceName.empty())
    {
        instanceName = communicator()->getDefaultLocator()->ice_getIdentity().category;
    }
    if (instanceName.empty())
    {
        instanceName = "IceGrid";
    }

I've yet to find anywhere that we document this in the docs. I think we should just use IceGrid.InstanceName

@externl externl added this to the 3.8.0 milestone Nov 12, 2024
@bernardnormier
Copy link
Member

bernardnormier commented Nov 12, 2024

We rely on the Ice.Default.Locator -derived instance name for the config files we ship, so we can't change this logic.

https://github.com/zeroc-ice/ice/blob/main/cpp/config/icegridnode.cfg

We should however fix the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants