Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server demos should show recommended server shutdown #181

Open
bernardnormier opened this issue Mar 15, 2023 · 0 comments
Open

Server demos should show recommended server shutdown #181

bernardnormier opened this issue Mar 15, 2023 · 0 comments

Comments

@bernardnormier
Copy link
Member

The recommended shutdown procedure for a server is to shut it down before destroying it. In some demos, the server is correctly shut down, for example:

communicator->shutdown();

In other demos, the server is just destroyed. While it doesn't matter for those demos, it's not the recommended style:

Console.CancelKeyPress += (sender, eventArgs) => communicator.destroy();

We should also consider not using communicator.waitForShutdown() in demos with no shutdown operation. All we need is a "WaitForCtrlC()".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant