Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [BetterRoleColors] Add support for advanced markdown like headers #738

Closed
Fungustober opened this issue Nov 1, 2023 · 1 comment

Comments

@Fungustober
Copy link

Which plugin/theme is this about?

BetterRoleColors

Describe the Bug

BetterRoleColors doesn't apply role colors to Header text in messages made using Discord's recent Markdown functionality.

To Reproduce

Type a #, a space, and then any text into Discord's message bar and send it.

Expected Behavior

I expected the Header text to also have color like the rest of the text in a message.

Screenshots

Screenshot 2023-10-31 223359 Screenshot 2023-10-31 223410

Discord Version

Stable

Additional Context

From investigating this, it seems that discord wraps the header markdown text in two spans, and then a h1, h2, or h3 element. I managed to select them in my own project by using div[class*="messageContent"] h1 span span but admittedly that was a quick and dirty solution after Discord's update wrecked everything.

@Fungustober Fungustober added the bug label Nov 1, 2023
@zerebos zerebos changed the title [Bug] BetterRoleColors doesn't apply role colors to Header text in messages [Feature] [BetterRoleColors] Add support for advanced markdown like headers Sep 16, 2024
@zerebos zerebos added enhancement and removed bug labels Sep 16, 2024
@zerebos
Copy link
Owner

zerebos commented Dec 15, 2024

Sorry but BetterRoleColors has been discontinued. I recommend using MoreRoleColors. I will CC the creator @DaddyBoard about your feature request!

@zerebos zerebos closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants