Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with the latest mpv version: fatal error: 'mpv/qthelper.hpp' file not found #114

Open
yurivict opened this issue Dec 4, 2020 · 5 comments

Comments

@yurivict
Copy link

yurivict commented Dec 4, 2020

libradiance_autogen/UVLADIE3JM/../../../radiance-0.6.1-60-gbaf2c40/src/MovieNode.h:12:10: fatal error: 'mpv/qthelper.hpp' file not found
#include <mpv/qthelper.hpp>
         ^~~~~~~~~~~~~~~~~~

Log: http://beefy18.nyi.freebsd.org/data/head-amd64-default/p556876_s368287/logs/radiance-video-0.6.1_1.log (IPv6 URL)

mpv-0.33.0

@yurivict yurivict changed the title Fails to build with the latest mpv: fatal error: 'mpv/qthelper.hpp' file not found Fails to build with the latest mpv version: fatal error: 'mpv/qthelper.hpp' file not found Dec 4, 2020
@gdkar
Copy link
Collaborator

gdkar commented Dec 5, 2020

qthelper.hpp was removed from mpv in march ( commit mpv-player/mpv@575197f )

i forget whether mpv's licensing would allow us to just pull that in

@yurivict
Copy link
Author

@gdkar Any chance to fix it?

@Marte2007
Copy link

Copying the file manually solves this error, triggering #110

Patch notes specifically say to do this, so it should not be a problem license-wise:
https://github.com/mpv-player/mpv/blob/575197ff8b0a0d8cd14f7ee78461c1d61d045d72/DOCS/client-api-changes.rst#api-changes

@enesdogan00
Copy link

Still having the same issue, how may I build the package?

@yurivict
Copy link
Author

It looks like this project isn't maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants