Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] TestRedisService.HugeCommandInline flaky in master #25436

Open
1 task done
spolitov opened this issue Dec 26, 2024 · 0 comments
Open
1 task done

[DocDB] TestRedisService.HugeCommandInline flaky in master #25436

spolitov opened this issue Dec 26, 2024 · 0 comments
Assignees
@spolitov
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@spolitov
Copy link
Contributor

spolitov commented Dec 26, 2024 •
edited by jira bot
Loading

Jira Link: DB-14673

Description

../../src/yb/yql/redis/redisserver/redisserver-test.cc:974
Expected equality of these values:
  reply_type
    Which is: kArray
  reply.get_type()
    Which is: kError
Originator: ../../src/yb/yql/redis/redisserver/redisserver-test.cc:1112, reply: {kError, Read RPC (request call id 278) to 127.0.0.2:19020 timed out after 60.000s}

Issue Type

kind/failing-test

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@spolitov spolitov added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Dec 26, 2024
@spolitov spolitov self-assigned this Dec 26, 2024
@yugabyte-ci yugabyte-ci added kind/failing-test Tests and testing infra priority/medium Medium priority issue kind/enhancement This is an enhancement of an existing feature labels Dec 26, 2024
spolitov added a commit that referenced this issue Dec 26, 2024
@spolitov
[#25436] DocDB: Fix GcMemory result
f14450e 
Summary:
MemTracker::GcMemory tries to release memory, then returns true if we still cannot consume requested amount of bytes.
There is a bug in logic, that return `false` if we already released enough memory.
It could lead to situation when RPC call or response will be rejected due to lack of memory, while actually we could handle it.

Fixed to returning `true` in this case.
Jira: DB-14673

Test Plan: ./yb_build.sh -n 200 --cxx-test redisserver_redisserver-test --gtest_filter TestRedisService.HugeCommandInline

Reviewers: timur

Reviewed By: timur

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D40911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spolitov @yugabyte-ci