Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ytgov-112: Travel Port Text Pop Up and Button #215

Merged

Conversation

klondikemarlen
Copy link
Member

@klondikemarlen klondikemarlen commented Aug 1, 2024

Fixes ytgov#112

Relates to:

  • Travel Desk Request
  • Travel options

Context

Is your feature request related to a problem? Please describe.
Related to the "Travel Port Text" button and subsequent pop-up
image

1.) Update titles to read horizontally
image

2.) Clean and separate options button does not work
image

Describe the solution you'd like
The user would copy some text from a different application and the Clean and separate options would parse the various components of the text into flight segments. That would appear in the flight segment region. The user could then group segments together into groupings and give the grouping a cost. Grouped segments would appear on the travel desk request screen.
image
image
image

Additional context
See sample text.

parsable-text.txt

Passenger:
ignore this info

Flights:
Air Canada AC303
Departure: 13 Jan 09:05 Pierre Elliott Trudeau Intl Arpt (YUL) Terminal:
Arrival: 13 Jan 11:53 Vancouver Intl Arpt (YVR) Terminal: M
Duration: 5 Hour(s) 48 Minutes
Status: Confirmed
Class: Q
Air Canada AC304
Departure: 13 Jan 09:05 Pierre Elliott Trudeau Intl Arpt (YUL) Terminal:
Arrival: 13 Jan 11:53 Vancouver Intl Arpt (YVR) Terminal: M
Duration: 5 Hour(s) 48 Minutes
Status: Confirmed
Class: Q

Hotels:
Hotel details here...

Cars:
Car rental details here...

Implementation

  1. Move away from unstable title card component, to standard Vuetify card component.
  2. Add minimal test for single example of parsing travel port(al?) text.
  3. Add front-end test setup.

Concerns

  1. The current implementation of the travel text parser is virtually impossible to read or debug, and is extremely fragile. A complete re-write is likely necessary before production use, with each new feature backed by multiple test cases.
  2. UI is composed of multiple layers of modals, and this violates both accessibility and basic usability considerations. It also makes it very difficult to perform future development and debugging.

Screenshots

Travel Desk -> Edit (modal) -> Travel Port Text (modal)
image
image
image

Testing Instructions

  1. Run the test suite via dev test web (or dev test_web)
  2. Boot the app via dev up
  3. Log in to the app at http://localhost:8080
  4. Click on "My Travel Requests" from the top nav drop down.
  5. Create travel request.
  6. Generate an estimate.
  7. Submit to yourself as the supervisor; this feature should be removed in production.
  8. Select "Manger View" from top nav drop down.
  9. Approve your request.
  10. Select "Travel Desk" from the to drop down nav.
  11. Check the box beside your travel request, then click on print.
  12. Check that this renders correctly, then exit the modal.
  13. Click the "edit" button for a particular travel desk request row to open the travel desk request edit modal.
  14. Click on the "Travel Port(al?) Text" call to action button.
  15. This opens the 2nd layer modal for managing group/flight options; see concerns.
  16. Enter the provide text; note this is the only text that is likely to work; see concerns.
  17. Check that the example parses.

@klondikemarlen klondikemarlen added the bug Something isn't working label Aug 1, 2024
@klondikemarlen klondikemarlen self-assigned this Aug 1, 2024
@klondikemarlen klondikemarlen force-pushed the ytgov-issue-112/travel-port-text-pop-up-and-button branch from c741a00 to 885caa6 Compare August 1, 2024 19:08
@klondikemarlen klondikemarlen force-pushed the ytgov-issue-112/travel-port-text-pop-up-and-button branch from 37b819c to d277a33 Compare August 23, 2024 17:10
@klondikemarlen klondikemarlen force-pushed the ytgov-issue-112/travel-port-text-pop-up-and-button branch 2 times, most recently from a7a6e24 to 5715d74 Compare September 18, 2024 23:55
Some objects where mistakenly arrays, and some arrays were mistakenly objects.
TitleCard appears to be breaking do to too many layers of modals.
Solution: Remove TitleCard and replace with v-card.
Switch from TitleCard to v-card.
Replace TitleCard with v-card.
Also standardize naming to kebab-case.
Particularly to test the failing parse travel function.
Why? so I can test the parse travel function.
I can't quite get the rule between two flight sections vs. ending the input to work.
Add path aliases so that we can import from "@/support" in our tests.
jsconfig.json updates alow F12 lookup to work in VS Code.
@klondikemarlen klondikemarlen force-pushed the ytgov-issue-112/travel-port-text-pop-up-and-button branch from a337e55 to baf9550 Compare September 19, 2024 18:45
@klondikemarlen klondikemarlen marked this pull request as ready for review September 19, 2024 22:02
@klondikemarlen klondikemarlen merged commit f11e7bf into main Sep 19, 2024
@klondikemarlen klondikemarlen deleted the ytgov-issue-112/travel-port-text-pop-up-and-button branch September 19, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Travel Port Text Pop-up and button
2 participants