forked from ytgov/travel-authorization
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ytgov-112: Travel Port Text Pop Up and Button #215
Merged
klondikemarlen
merged 25 commits into
main
from
ytgov-issue-112/travel-port-text-pop-up-and-button
Sep 19, 2024
Merged
Ytgov-112: Travel Port Text Pop Up and Button #215
klondikemarlen
merged 25 commits into
main
from
ytgov-issue-112/travel-port-text-pop-up-and-button
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klondikemarlen
force-pushed
the
ytgov-issue-112/travel-port-text-pop-up-and-button
branch
from
August 1, 2024 19:08
c741a00
to
885caa6
Compare
klondikemarlen
force-pushed
the
ytgov-issue-112/travel-port-text-pop-up-and-button
branch
from
August 23, 2024 17:10
37b819c
to
d277a33
Compare
klondikemarlen
force-pushed
the
ytgov-issue-112/travel-port-text-pop-up-and-button
branch
2 times, most recently
from
September 18, 2024 23:55
a7a6e24
to
5715d74
Compare
Some objects where mistakenly arrays, and some arrays were mistakenly objects.
TitleCard appears to be breaking do to too many layers of modals. Solution: Remove TitleCard and replace with v-card.
Switch from TitleCard to v-card.
Replace TitleCard with v-card.
Also standardize naming to kebab-case.
Particularly to test the failing parse travel function.
Why? so I can test the parse travel function.
I can't quite get the rule between two flight sections vs. ending the input to work.
Add path aliases so that we can import from "@/support" in our tests. jsconfig.json updates alow F12 lookup to work in VS Code.
klondikemarlen
force-pushed
the
ytgov-issue-112/travel-port-text-pop-up-and-button
branch
from
September 19, 2024 18:45
a337e55
to
baf9550
Compare
Mostly outdated variables and stuff like that.
Why? To make it easier to see action buttons.
klondikemarlen
deleted the
ytgov-issue-112/travel-port-text-pop-up-and-button
branch
September 19, 2024 22:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ytgov#112
Relates to:
Context
Additional context
See sample text.
parsable-text.txt
Implementation
Concerns
Screenshots
Travel Desk -> Edit (modal) -> Travel Port Text (modal)
Testing Instructions
dev test web
(ordev test_web
)dev up