Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph_train.py --mem flag #4

Open
mcleish7 opened this issue Feb 2, 2023 · 4 comments
Open

Graph_train.py --mem flag #4

mcleish7 opened this issue Feb 2, 2023 · 4 comments

Comments

@mcleish7
Copy link

mcleish7 commented Feb 2, 2023

Good Afternoon,

The --mem flag in graph_train.py, does not appear to be used.
Only being called:

  1. When declaring iterativeFC
  2. When declaring GraphEBM

However, it is not used in either constructors: IterativeFC nor EBM.

My testing is showing a large difference in loss when the --mem flag is turned on. What does the flag do please.

Thanks,
Sean

@yilundu
Copy link
Owner

yilundu commented Feb 2, 2023

Hi,

In the model, the --mem flag should add a computational scratchpad to models, so that that not only is an output optimization, but also an intermediate latent "scratchpad".

Best,
Yilun

@mcleish7
Copy link
Author

mcleish7 commented Feb 2, 2023

Thank you for the quick response.
Just to clarify, the scratchpad is not currently implemented for the graph models, so the --mem flag should have no impact currently?

Thanks,
Sean

@yilundu
Copy link
Owner

yilundu commented Feb 2, 2023

I believe so -- it should only do something on the MLP models

@mcleish7
Copy link
Author

mcleish7 commented Feb 3, 2023

Thank you so much for the help.

I have another question, if that is okay. The edge weights for the shortest path data set are drawn, independently, from a uniform distribution and then added to their own transpose as the graph is undirected so the matrix should be symmetric.
However, in 'Appendix C-Graphical Algorithmic Computation' of the paper for the models, it states edge weights are drawn from a uniform distribution on [0,1], not the the addition of two. Could you confirm which one was used please.

Thanks,
Sean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants