Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we start implementing FTP? #218

Closed
carlosmiranda opened this issue Nov 24, 2014 · 3 comments
Closed

How do we start implementing FTP? #218

carlosmiranda opened this issue Nov 24, 2014 · 3 comments

Comments

@carlosmiranda
Copy link
Collaborator

I'm assigned to perform #213, which asks for a FTP endpoint implementation.

Design wise, I believe all we need to do is within the s3auth-relay module. Our architecture is coherent enough to separate the protocol communications in s3auth-relay to the actual resource access in s3auth-hosts. Basically, all the FTP support needs to be in s3auth-relay, is this right?

A more important question to me is what is the "minimum" that we need to implement so that we can say that we "support" FTP, if not fully? I'm not very familiar to the internals of the FTP protocol so some guidance on this matter would be of great assistance.

@yegor256
Copy link
Owner

You're right, we have to implement it inside s3auth-relay. I would start with a test.. Create a test that will use a real FTP client and will try to do a few basic FTP commands, in this order:

OPEN ftp://maven.s3auth.com
USER s3auth s3auth
CD apidocs
LIST
GET index.html
QUIT

Actually, that's all we need to support: OPEN, USER, CD, LIST, GET, QUIT

@carlosmiranda
Copy link
Collaborator Author

@yegor256 Thanks for your reply. I'm just curious as to why you consider this ticket "invalid", did I not raise a valid question?

@yegor256
Copy link
Owner

@carlosmiranda look at this article: http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html (published it a few minutes ago). Pay attention to the fifth principle.

@pinaf pinaf mentioned this issue Jan 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants