Support awaiting optional Promises #49
Open
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow optional chaining inside an 'await' function, eg:
try await(self.foo?.bar())
If the promise is 'nil', 'await' immediately returns 'nil' and does
nothing more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
===========================================
- Coverage 100.00% 97.64% -2.36%
===========================================
Files 4 4
Lines 75 85 +10
===========================================
+ Hits 75 83 +8
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
|
Hey @yannickl, what's the status on this PR? Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
awaiting optional promises, which allows for optional chaining inside anawaitfunction, like so:If the promise is
nil,awaitimmediately returnsniland does nothing more; otherwise it executes the promise as normal and returns anOptionalwrapping the awaited value. This is implemented for bothPromises andGuarantees.This should resolve #19 — please let me know what you think, and thank you for providing this library!