Merge pull request #73 from shinriyo/patch-4

check valid xml before parse
xtyxtyx · Sep 13, 2024 · 38913da · 38913da
2 parents 6a8c4fc + 5b2ec32
commit 38913da
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/lib/src/minio_helpers.dart b/lib/src/minio_helpers.dart
@@ -225,8 +225,14 @@ void validate(MinioResponse response, {int? expect}) {
     if (response.body.isEmpty) {
       error = Error(response.reasonPhrase, null, response.reasonPhrase, null);
     } else {
-      final body = xml.XmlDocument.parse(response.body);
-      error = Error.fromXml(body.rootElement);
+      // check valid xml
+      if (response.body.startWith('<?xml')) {
+        final body = xml.XmlDocument.parse(response.body);
+        error = Error.fromXml(body.rootElement);
+      } else {
+        // not valid xml
+        error = Error(response.reasonPhrase, null, response.reasonPhrase, null);
+      }
     }
 
     throw MinioS3Error(error?.message, error, response);