Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message is sent to inactive devices #197

Closed
eriktelepovsky opened this issue Feb 11, 2022 · 2 comments
Closed

Message is sent to inactive devices #197

eriktelepovsky opened this issue Feb 11, 2022 · 2 comments
Labels

Comments

@eriktelepovsky
Copy link

Hi.

The README mentions that "devices marked as inactive will not be sent notifications" but it is actually not true. When you send message using device.send_message(), it is sent regardless the device is inactive.

The "active" value of boolean field is not checked anywhere in the code when sending message. Only when deactivating devices.

@xtrinch
Copy link
Owner

xtrinch commented Mar 22, 2022

self.filter(active=True).values_list("registration_id", flat=True)

Yeah you're right it is only checked when sending in bulk, not when sending a single message.
We should fix this.

@xtrinch
Copy link
Owner

xtrinch commented May 9, 2024

Fixed in #262

@xtrinch xtrinch closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants