Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some hard-coded values #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

book
Copy link
Collaborator

@book book commented May 26, 2016

$nr_of_rows and $pages_per_set where respectively set to 5 and 7
in several files.

Since $nr_of_rows was set to config->{posts_on_page} in
lib/PearlBee/Posts.pm, the obvious fix was to follow that example and
make those values configurable in the main config.yml.

Defaults are assigned at the application startup, so there is no need
to further check if the values are valid.

posts_on_page still has a number of issues:

  • it should probably be named posts_per_page
  • it is actually used different things, like limiting the number of
    users or comments shown in the dashboard

Further improvements include the addition of users_per_page,
comments_per_page, etc.

This fixes #1.

$nr_of_rows and $pages_per_set where respectively set to 5 and 7
in several files.

Since $nr_of_rows was set to config->{posts_on_page} in
lib/PearlBee/Posts.pm, the obvious fix was to follow that example and
make those values configurable in the main config.yml.

Defaults are assigned at the application startup, so there is no need
to further check if the values are valid.

posts_on_page still has a number of issues:
- it should probably be named posts_per_page
- it is actually used different things, like limiting the number of
  users or comments shown in the dashboard

Further improvements include the addition of users_per_page,
comments_per_page, etc.
andrewalker pushed a commit to andrewalker/PearlBee that referenced this pull request Nov 18, 2017
added changed filles (js for toggle)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard-coded values
1 participant