Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded values #1

Open
2 tasks
xsawyerx opened this issue Dec 29, 2015 · 1 comment · May be fixed by #34
Open
2 tasks

Hard-coded values #1

xsawyerx opened this issue Dec 29, 2015 · 1 comment · May be fixed by #34
Assignees
Labels

Comments

@xsawyerx
Copy link
Owner

A bunch of stuff are hard-coded.

  • $nr_of_rows
  • $pages_per_set
@xsawyerx xsawyerx added the bug label Feb 24, 2016
@xsawyerx xsawyerx modified the milestone: May 2016 Apr 29, 2016
@book book self-assigned this May 26, 2016
@book
Copy link
Collaborator

book commented May 26, 2016

The config.yml file has a posts_on_page setting, that is once used to set the value for $nr_of_rows:

# lib/PearlBee/Posts.pm
        my $nr_of_rows
            = config->{'posts_on_page'} || 5; # Number of posts per page

So I'll do the following:

  • set the value to the default of 5 at startup (after the config has been read)
  • use the config->{'posts_on_page'} everywhere it makes sense
  • do the same for $pages_per_set (i.e. add it to config.yml)

@book book linked a pull request May 26, 2016 that will close this issue
andrewalker pushed a commit to andrewalker/PearlBee that referenced this issue Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants