Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression-session deprecations #5

Open
navels opened this issue Jan 14, 2016 · 2 comments
Open

expression-session deprecations #5

navels opened this issue Jan 14, 2016 · 2 comments

Comments

@navels
Copy link

navels commented Jan 14, 2016

Just tried this out with the latest versions of express (4.13.3) and express-session (1.12.1) and got these warnings:

express-session deprecated undefined resave option; provide resave option at node_modules/socket.io-express-session/index.js:4:5
express-session deprecated undefined saveUninitialized option; provide saveUninitialized option at node_modules/socket.io-express-session/index.js:4:5
express-session deprecated req.secret; provide secret option at node_modules/socket.io-express-session/index.js:4:5
@compoundf
Copy link

I also just tried this a few minutes ago and got the same errors. This package looks very promising if there's a way to get past these. Anyone?

@danasilver
Copy link

Using a default option (not explicitly specifying an option) for resave and saveUninitialized is deprecated in express-session. See expressjs/session#123 and the express-session Readme.

Similarly secret is required.

See how the example sets all three options: https://github.com/xpepermint/socket.io-express-session/blob/master/example/index.js#L4. The example runs without any deprecation warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants