ENH: Refine connection exception handling #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix xorbitsai#110 while server-side recv invalid format data, previously will not handle exception and leaving connection not close
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 88.97% 84.77% -4.21%
==========================================
Files 48 53 +5
Lines 4038 4571 +533
Branches 770 498 -272
==========================================
+ Hits 3593 3875 +282
- Misses 358 597 +239
- Partials 87 99 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
frostyplanet
changed the title
qinxuye
reviewed
Nov 20, 2024
qinxuye
reviewed
Nov 20, 2024
qinxuye
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
While server-side recv invalid format data, previously will not handle exception and leaving connection not close.
The exception situation including invalid header, or deserialization fails
Related issue number
Fixes #110
Check code requirements
None