Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: determine the timeout default and zero value for cred.WaitUntilFetched(ctx) #50

Closed
denopink opened this issue Mar 28, 2024 · 0 comments · Fixed by #117
Closed

feat: determine the timeout default and zero value for cred.WaitUntilFetched(ctx) #50

denopink opened this issue Mar 28, 2024 · 0 comments · Fixed by #117
Assignees
@denopink
Labels
enhancement improvement or small functionality added to an existing feature

Comments

@denopink
Copy link
Contributor

denopink commented Mar 28, 2024 •
edited
Loading

xmidt-agent/cmd/xmidt-agent/main.go

Lines 227 to 230 in 1b1515e

ctx, cancel := context.WithTimeout(ctx, 30*time.Second)
defer cancel()
// blocks until an attempt to fetch the credentials has been made or the context is canceled
cred.WaitUntilFetched(ctx)

@denopink denopink added the enhancement improvement or small functionality added to an existing feature label Mar 28, 2024
@denopink denopink changed the title Determine the timeout default and zero value for cred.WaitUntilFetched(ctx) feat: determine the timeout default and zero value for cred.WaitUntilFetched(ctx) Mar 28, 2024
@denopink denopink self-assigned this May 9, 2024
denopink added a commit that referenced this issue May 10, 2024
@denopink
feat: #50 add WaitUntilFetched as a configurable value
a2b0e83 
`WaitUntilFetched` is the time the xmidt-agent blocks on startup until an attempt to fetch the credentials has been made.
@denopink denopink linked a pull request May 10, 2024 that will close this issue
feat: #50 add WaitUntilFetched as a configurable value #117
Merged
@denopink denopink mentioned this issue May 13, 2024
Merged
schmidtw added a commit that referenced this issue May 15, 2024
@schmidtw
Merge pull request #117 from xmidt-org/denopink/feat/timeout-config-f…
f232afc 
…or-cred-fetch

feat: #50 add `WaitUntilFetched` as a configurable value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denopink denopink

Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #50 add WaitUntilFetched as a configurable value xmidt-org/xmidt-agent
1 participant
@denopink