Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.SetDefaults doesn't work for timeouts #280

Open
kristinapathak opened this issue Jun 13, 2022 · 0 comments
Open

v.SetDefaults doesn't work for timeouts #280

kristinapathak opened this issue Jun 13, 2022 · 0 comments
Labels

Comments

@kristinapathak
Copy link
Contributor

tr1d1um/main.go

Line 124 in 67dddb6

v.SetDefault(k, va)

This code doesn't work for all the listed defaults currently:

var defaults = map[string]interface{}{

Now that some timeout values are under the xmidtClientTimeout key, it needs to be included when setting those three timeout defaults.

tr1d1um/main.go

Line 349 in 67dddb6

err := v.UnmarshalKey("xmidtClientTimeout", &timeouts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant