Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing CRRao Tests #123

Closed
ShouvikGhosh2048 opened this issue Jun 16, 2023 · 5 comments
Closed

Failing CRRao Tests #123

ShouvikGhosh2048 opened this issue Jun 16, 2023 · 5 comments

Comments

@ShouvikGhosh2048
Copy link
Collaborator

The CRRao Tests are failing due to a ADGradient error.

A similar error occurs in this program:

using Turing, StableRNGs

@model function example(x)
    m ~ Normal(0, 1)
    x ~ Normal(m, sqrt(1))
end

res = sample(StableRNG(123), example(1), NUTS(), 10)

This issue might be related to this issue.

@ayushpatnaikgit
Copy link
Member

Seems to be working on Turing v0.26.0, which version are you using?

@ShouvikGhosh2048
Copy link
Collaborator Author

ShouvikGhosh2048 commented Jun 16, 2023

I was using v0.23.3. That might have been the issue. CRRao also currently uses v0.23.3 which might be causing it's tests to fail.

@ayushpatnaikgit
Copy link
Member

Okay, I've removed the old version of Turing in this PR.
#121

Let's wait for the CI to complete.

This was referenced Jul 20, 2023
@ayushpatnaikgit
Copy link
Member

These two logistic regression tests are failing

(prior, link) = (Prior_HorseShoe(), Logit(CRRao.Logit_Link))
(prior, link) = (Prior_HorseShoe(), Probit(CRRao.Probit_Link))

For Negative binomial, we get an error outside the test:
zero(p) < p <= one(p)

These are the only two errors.

@sourish-cmi
Copy link
Collaborator

It is being fixed and new release 0.1.1 is being done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants