Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using sql alchemy instead of psycopg as core sql library #9

Open
matthewgee opened this issue Apr 3, 2018 · 2 comments
Open
Assignees

Comments

@matthewgee
Copy link
Member

Do we want to preserve the ability for abacus users to easily be able to use the library with a non-PostgreSQL data store or even structured CSVs?

Essentially separate our the connection and query methods from the calculations. I can be convinced otherwise.

@tplagge
Copy link
Collaborator

tplagge commented Apr 4, 2018

Connection/query and calculation methods are already separated, but the connection/query routines (in input_db) do assume Postgres. This would be a relatively painless change if we wanted to support non-Postgres databases, and in fact I'm about 100% certain we'll need to do this for queries to the wage records database. Fairly low priority at the moment, but this is a good change to keep on our radar.

@NdagiStanley NdagiStanley removed their assignment Feb 10, 2022
@NdagiStanley
Copy link
Contributor

Just came across this as an open issue. Does it make sense to close this issue and mark the repo as archived since I'm not seeing recent activity in it?

cc @matthewgee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants