refactor: 카카오 로그인 관련 로직 DataSource 리팩터링 #931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haeum808
reviewed
Dec 21, 2024
| import com.mulberry.ody.domain.model.AuthToken | ||
| import javax.inject.Inject | ||
|
|
||
| class DefaultRemoteAuthDataSource |
There was a problem hiding this comment.
DefaultRemoteAuthDataSource -> KaKaoRemoteAuthDataSource 어떤가요?
Default로 네이밍한 이유가 궁금합니다!
| import retrofit2.http.POST | ||
|
|
||
| interface LoginService { | ||
| interface AuthService { |
| @@ -12,7 +12,7 @@ import javax.inject.Inject | |||
| @AndroidEntryPoint | |||
| class FCMService : FirebaseMessagingService() { | |||
| @Inject | |||
| lateinit var fcmTokenRepository: FCMTokenRepository | |||
| lateinit var odyDatastore: OdyDatastore | |||
|
지금와서 보니 local, remote로 리포지토리를 나누는게 이상한거 같네요! local, remote 패키지 없애고 리포지토리만 있어도 괜찮을거 같아요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
close #930
📝 작업 내용
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)
기존에는 data 패키지 하위에 local, remote 패키지만 있어서 local or remote 내부에 repository를 위치시켰는데,
KakaoAuthRepository는 local과 remote 둘다 포함하고 있어서 어떤 패키지에 위치 시�킬지 애매하더라고요.그래서 위 사진처럼 data/auth 패키지를 따로 두었습니다.
추후에는 data 패키지 바로 하위에 repository 패키지가 있어도 괜찮을 것 같아요. !!!
일단 더 고민해보고 data 패키지 관련 구조 변경 이슈는 따로 팔 예정입니다.. 혹시 괜찮은 의견 있다면 공유 부탁드려요!!