refactor: notification을 타입계층으로 리팩터링 #929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Test Results 62 files 62 suites 13s ⏱️ Results for commit deb422d. |
📝 Test Coverage Report
|
coli-geonwoo
commented
Dec 14, 2024
| @@ -195,5 +204,46 @@ void returnMissing_When_isMissing_Mate() { | |||
| assertThat(mateEtaResponses.mateEtas().get(1).status()).isNotEqualTo(EtaStatus.MISSING); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
리팩터링으로 인해 findAllMeetingLogsOrderOfEntryAndDepartureNotification()를 대체할 테스트를 인수 테스트로 추가하였습니다.
coli-geonwoo
commented
Dec 14, 2024
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Mockito; | ||
|
|
||
| class DepartureReminderTest { |
There was a problem hiding this comment.
발송 시점이 현재 시점보다 이른 경우, 즉시 발송한다는 책임은 NotificatinService가 아닌 DepartureReminder의 내부 로직으로 캡슐화되어 테스트를 이전했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
close #926
📝 작업 내용
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)
❌ 아직 리뷰하지 말아주세요 -> PR 관련 노션 페이지 작성 예정