Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] 레코드 락 위한 인덱스 명시(#796) #797

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[BE] 레코드 락 위한 인덱스 명시(#796) #797

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 2, 2024 •
edited by youngsu5582
Loading

📌 관련 이슈

✨ PR 세부 내용

의도적으로 이와 같이 시간을 걸어 락 조회해서 확인 결과

  @Transactional
  public void execute(long roomId) {
      automaticMatchingRepository.findByRoomIdAndStatusForUpdate(roomId, ScheduleStatus.PENDING)
              .ifPresent(automaticMatching -> {
                  Thread.sleep(10000);
                  matchingExecutor.match(roomId);
                  automaticMatching.updateStatusToDone();
              });
  }
mysql> select am1_0.id,am1_0.create_at,am1_0.matching_start_time,am1_0.room_id,am1_0.status from automatic_matching am1_0 where am1_0.room_id=99 and am1_0.status='PENDING' for update;
Empty set (9.89 sec)

다른 레코드도 이처럼 락이 걸립니다.
이를 인덱스를 통해 해결했습니다.

추가적으로 테스트도 조금 수정했습니다.
우선, 기존에 AsyncConfig가 비동기가 아닌 동기 Task 를 유도하게 한 점 변경했습니다.
이에 따라 정말 비동기 테스트가 필요한 곳 아닌곳은 SyncConfig 를 통해 테스트가 용이하게 했습니다.

@github-actions github-actions bot added BE 백엔드 개발 관련 작업 기능 기능 구현 작업 labels Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Dec 2, 2024 •
edited
Loading

Test Results

 70 files   70 suites   9s ⏱️
235 tests 217 ✅ 18 💤 0 ❌
247 runs  229 ✅ 18 💤 0 ❌

Results for commit c8865c1.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashsty ashsty Awaiting requested review from ashsty

@hjk0761 hjk0761 Awaiting requested review from hjk0761

@jcoding-play jcoding-play Awaiting requested review from jcoding-play

At least 2 approving reviews are required to merge this pull request.

Assignees

@youngsu5582 youngsu5582

Labels
BE 백엔드 개발 관련 작업 기능 기능 구현 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 레코드 락 위한 인덱스 명시
1 participant
@youngsu5582