Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline styles #4616

Open
3 tasks done
zc-devs opened this issue Dec 24, 2024 · 0 comments
Open
3 tasks done

Inline styles #4616

zc-devs opened this issue Dec 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@zc-devs
Copy link
Contributor

zc-devs commented Dec 24, 2024

Component

web-ui

Describe the bug

The code contains the inline styles.
Inline style, seems, was only in web/src/components/admin/settings/queue/AdminQueueStats.vue:25 before.

Expected behavior

Should not be inline styles.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/style
https://stackoverflow.com/questions/2612483/whats-so-bad-about-in-line-css
https://content-security-policy.com/unsafe-inline/

System Info

next

Additional context

I accidentally saw #4609 and wanted to comment there, but I'm not allowed to comment on pat-s issues and PRs.

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
@zc-devs zc-devs added the bug Something isn't working label Dec 24, 2024
@zc-devs zc-devs changed the title Inline styles and scripts Inline styles Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant