Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Without a Reviewers line, cpr still tries to set reviewers #17

Open
wjmelements opened this issue Sep 5, 2018 · 0 comments
Open

Without a Reviewers line, cpr still tries to set reviewers #17

wjmelements opened this issue Sep 5, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@wjmelements
Copy link
Owner

We should skip the set-reviewers step when no reviewers are supplied.

From the output of cpr without a reviewers line:

Sending pull request...
https://github.com/dydxprotocol/protocol/pull/435 (copied to clipboard)
Setting reviewers...
Validation Failed
Could not add requested reviewers to pull request.
@wjmelements wjmelements added the bug Something isn't working label Sep 5, 2018
wjmelements pushed a commit that referenced this issue Jan 29, 2019
@terryli0095
Merge pull request #17 from wjmelements/fix-provider-url
805c01d 
Fix Provider Url
wjmelements added a commit that referenced this issue Nov 21, 2019
@wjmelements @terryli0095
registryAttributes -l (#17)
06a4ec9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wjmelements