-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc template on mobile unable to access social menu #978
Comments
Thanks for the issue @magicDGS! This is something we’re aware of and already asked our designer to propose a solution: Rendering here is done with the
We’d need to add There’s a few more considerations needed probably in terms of layout for the various combinations with/without social icons and with/without the language select and we’ll also need to think about how this all wraps if there are too many icons to fit on a narrow viewport (I try to make sure things work OK at least down to a 280px viewport). If you think you’d like to try and make a PR, please feel free to ask any more questions and we’ll do our best to help you get going! |
Thank you @delucis for the guidance here. I did a PR adding the changes, I have test locally and also on the netlify deployment from the PR and looks alright. But I have the following questions:
|
Left a suggestion to wrap them in the PR.
Yeah! You could also just temporarily add a few links and share a screenshot in the PR. |
What version of
starlight
are you using?0.11.1
What version of
astro
are you using?0.11.1
What package manager are you using?
npm
What operating system are you using?
Windows
What browser are you using?
Firefox/Chrome
Describe the Bug
In the basic example directly, there is no way to access on mobile the social links on a documentation page (docs template). The menu shows at the end of the navigatio the theme (and the language), but the social icons aren't. This is probably related to #977
I haven't mark checkbox to participate with a PR, but I am willing to do so if I have some guidance as I am not familiar with the codebase (nor too much with javascript yet, although I have experience on other programming languages and software development in general).
Link to Minimal Reproducible Example
https://stackblitz.com/github/withastro/starlight/tree/main/examples/basics
Participation
The text was updated successfully, but these errors were encountered: