Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers from response #2

Open
xBioDreadx opened this issue Oct 31, 2019 · 2 comments
Open

Headers from response #2

xBioDreadx opened this issue Oct 31, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@xBioDreadx
Copy link

xBioDreadx commented Oct 31, 2019

Hi, im currently parse website that require authentication for access to some content.
So I log in with browser, copy all created cookies and add them with each parse request.

    void editRequest(BoundRequestBuilder req, * *, * *) {
        cookieService.cookies.each { req.addCookie(it) }
    }

That works like a charm until website change cookies in response - short after this my cookies are invalid and we dont receive desired response.
When I was looking for access to the response headers information like "set-cookie", I found this:

public final class RequestCoreHandler

 public String getResponse() {
   response = resp.getResponseBody();
    **
    **
   return response;
}

As i see we dont have any access to response information therefore we can't react to website response changes by any way except of response body.

Can we have access to other response information? Because in our case - we need it to correct following parse requests by headers (set-cookie), received in response.
What do you think about it? (if you want me to change it by myself - give at least some advice please).

@xBioDreadx xBioDreadx changed the title Cookies from response Headers from response Oct 31, 2019
@Louis-wht
Copy link
Contributor

Hello!

Sorry about that delay, I'm not using that account too often now, I use another github account.
Happy to see that you're using this library and want to contribute!

I kinda lost the accesses to the maven and sonatype accounts since the company I published this library for is now closed. Thus I can't release a new version.

However, I'd be happy to have have your PR, review it and approve it.

Eventually, I'm thinking of deploying this library with github package https://github.com/features/package-registry
It's free for open source, and we could auto deploy new versions of the library with some free CI plugin (free for open source projects as well), using github secrets. I don't know how exactly, but I know this is do-able.

But I'm not sure I have the availability to do it at the moment.

Let me know if you're still interested in helping !

Thanks for your interest in this project once again!

@Louis-wht Louis-wht added the good first issue Good for newcomers label Nov 5, 2019
@xBioDreadx
Copy link
Author

xBioDreadx commented Dec 13, 2019

Sry for so late response - had a lot of work..
This project - is the best solution for scrapping data with java/spring that i managed to find.
So its sure worth developing and supporting.
So what we begin from?
Id like to compare your vision of scrapper tasks queue workflow that this library is designed for - with mine.
About git CI - worked with it, but dont configured it myself - dont think that will be too hard.
Maybe it will be more comfortable to use some messenger?
email: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants