Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdnaTestV2.json "xn--xn--a--gua.pt" test case problem #803

Closed
domenic opened this issue Nov 5, 2023 · 5 comments
Closed

IdnaTestV2.json "xn--xn--a--gua.pt" test case problem #803

domenic opened this issue Nov 5, 2023 · 5 comments

Comments

@domenic
Copy link
Member

domenic commented Nov 5, 2023

What is the issue with the URL Standard?

When updating jsdom/tr46 to the latest revision of TR46, I implemented this new line of the label validity criteria:

If not CheckHyphens, the label must not begin with “xn--”.

This causes my test suite to fail due to these lines from IdnaTestV2.json:

  {
    "comment": "V2 (ignored)",
    "input": "xn--xn--a--gua.pt",
    "output": "xn--xn--a--gua.pt"
  },

which correspond to these lines from IdnaTestV2.txt:

xn--xn--a--gua.pt; xn--a-ä.pt; [V2]; xn--xn--a--gua.pt; ; ;  # xn--a-ä.pt

I can't tell whether this is a problem with the source data, or with our conversion script. The conversion script seems to be trying to do something with the V2 error codes, but I'm not sure exactly what.

Note that other V2 error codes in the test data don't seem to cause problems.

@domenic
Copy link
Member Author

domenic commented Nov 5, 2023

This is probably related to #760

@annevk
Copy link
Member

annevk commented Nov 6, 2023

This is a new criteria in UTS 46 v31 vs v29. Contrast with https://www.unicode.org/reports/tr46/tr46-29.html#Validity_Criteria.

It's not entirely clear to me if all the changes made to UTS 46 are correct. Notably we were not consulted on them.

@domenic
Copy link
Member Author

domenic commented Nov 6, 2023

I think this one might have been a result of our requests, or at least an interpretation of our requests. See #760. In particular I think it might align with WebKit, and thus avoid the roundtripping problems others see.

@rmisev
Copy link
Member

rmisev commented Nov 6, 2023

I think the problem is in IdnaTestV2.txt (from Unicode 15.1). The test you mention is missing the V4 label. There should be:

xn--xn--a--gua.pt; xn--a-ä.pt; [V2, V4]; xn--xn--a--gua.pt; ; ;  # xn--a-ä.pt

This is related to: #603

@annevk
Copy link
Member

annevk commented Nov 29, 2024

Let's close this in favor of web-platform-tests/wpt#48301 and #836 that will end up resolving this.

It seems your implementation is indeed correct and browsers are a bit behind.

@annevk annevk closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants