Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api for Sonarr v4 #46

Closed
wants to merge 4 commits into from
Closed

Update api for Sonarr v4 #46

wants to merge 4 commits into from

Conversation

Yankees4life
Copy link

Updated the api urls for support for v4 as v4 as deprecated the v1 api.

whatdaybob added a commit that referenced this pull request Jan 25, 2023
@whatdaybob
#46 Update api for Sonarr v4
0bb9f32
whatdaybob
whatdaybob reviewed Jan 25, 2023
View reviewed changes
Copy link
Owner

@whatdaybob whatdaybob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yankees4life I have submitted changes for v4, I have no way of testing though so can you please do the honours. Under sonarr in config.yml add version: v4

@whatdaybob whatdaybob self-requested a review January 25, 2023 21:29
@whatdaybob whatdaybob self-assigned this Jan 25, 2023
@whatdaybob whatdaybob added the enhancement New feature or request label Jan 25, 2023
@whatdaybob whatdaybob linked an issue Jan 25, 2023 that may be closed by this pull request
Issue communicating with sonarr! #44
Open
@Yankees4life
Copy link
Author

I tested it out and it runs fine.

@dotneB
Copy link

dotneB commented Jan 26, 2023

I'm getting

2023-01-26 23:26:11,101 - sonarr_youtubedl - DEBUG - Begin call Sonarr to rescan for series_id: 192
2023-01-26 23:26:11,101 - sonarr_youtubedl - ERROR - Failed - Ominous Lectures - Replacement index 1 out of range for positional args tuple

Seems to be comming from these lines from @whatdaybob's commits 0bb9f32

res = self.request_put(
            "{}/{}/command".format(self.base_url),
            None, 
            self.sonarr_api_version,
            data
        )

should be

res = self.request_put(
            "{}/{}/command".format(self.base_url, self.sonarr_api_version),
            None,
            data
        )

@whatdaybob
Copy link
Owner

I will fix this as soon as I have some free time unless someone can pull request it and I'll be happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatdaybob whatdaybob Awaiting requested review from whatdaybob

Assignees

@whatdaybob whatdaybob

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue communicating with sonarr!
3 participants
@Yankees4life @dotneB @whatdaybob