Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: startup configurability #5

Open
teaguecl opened this issue Oct 15, 2016 · 3 comments
Open

Feature request: startup configurability #5

teaguecl opened this issue Oct 15, 2016 · 3 comments

Comments

@teaguecl
Copy link

It would be nice if entrypoint.sh could be extended by the user. For example, it could execute /config/entrypoint-pre.sh before doing any work (if that file exists), and /config/entrypoint-post.sh after. My motivation for the request is that I had to modify entrypoint.sh to use a umask of 000 instead of 002. I could have put it in entrpoint-post.sh and not had to modify the container.

@wernight
Copy link
Owner

It's not standard to have those, as you said people usually then build their own container based on one.

The umask is probably a fair point as I think it's common to wish for qBT to have other masks. Could you just give you motivation for having another mask?

@teaguecl
Copy link
Author

Fair point regarding the extra scripts. My desire to change the umask is that I have a process that runs outside the container on the host, which needs to copy, move and/or rename the files that get downloaded. I could create a user on the host with UID 520, but I really don't need another user account to get what I need done.

@wernight
Copy link
Owner

wernight commented Oct 16, 2016

I made it so that qBT can work with any UID/GID so you can also start with --user $UID:$GID (any int:int). Also as long as your external process is running as the same GID (or same group) it also should work.

The reason I didn't give write-all to everyone is that I feel it's better to limit by default and it should be easy enough to have apps that need access get that access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants